fix(webconnectivityqa): Always close the QAEnv #1245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff fixes a bug in the webconnectivityqa tests which we discovered due to the new quic-go API panicking (#1161 (comment)).
The bug was that we did not close the
QAEnv
in some of our webconnectivityqa tests. Therefore, the QUIC Server would not close the underlying UDP socket (net.PacketConn
) and the local address of this socket would not be removed from the QUIC multiplexer.In the subsequent test case, the new quic-go API (see #1161) would panic because the local address of the server would still be registered in the global QUIC multiplexer.