-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] (Content) - Wave 8 mini expansions #526
Conversation
Torgen's suggestions. Also, changing 'elementaltoken' to 'elemental token'.
Thanks @Torgen - FYI I also changed 'elementaltoken' to 'elemental token' |
FYI, am pretty close to having the Descent data entered, including friends and foes. Will probably make that a single PR, then a separate one for the code changes to make the friends and foes selectable in settings and allow picking them at random. |
Awesome ty @Torgen. I can work on the promos and The Abyss, though you could add the friends and foes from The Caverns and The Abyss? |
Option 1 is if my PR gets merged first, you rebase so you can see the type changes that add friends and foes, then I do a PR into your branch to add them. Option 2 is you clone this PR into one against my branch and we end up with one big PR. |
All content from the minis aside from friends and foes and banners should be in this PR now. @Torgen option 1 sounds good |
There are no friends, foes, or banners in TOG, right? We didn't get that one. |
TOG only has 2 supply cards and a mage |
Not including Xaxos friend boons.
Hey @deusabianca is this ready for a final review and merge? |
@on3iro Yes should be good to go! |
@deusabianca thanks for the PR. Could you please do the following:
(I would've done this myself, however it seems you are probably using windows and your line endings are not configured properly. I tried to fix this quickly on my local machine, but didn't quite get it right and I am really short on time right now. I thought our |
I am still very much a noob with Github so the best way I found to do that I made a new pull request. I hope that's fine and we can close this one. |
Sure no - problem :) thanks @deusabianca |
This consists of The Caverns, The Abyss, Tales of Old Gravehold and promos