Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave 8 Content - Contribution Discussion #522

Closed
deusabianca opened this issue Nov 18, 2024 · 4 comments
Closed

Wave 8 Content - Contribution Discussion #522

deusabianca opened this issue Nov 18, 2024 · 4 comments
Assignees

Comments

@deusabianca
Copy link
Contributor

I can slowly work on adding wave 8 content once I get it, but if anyone who gets it before me wants to do that, let us know here.

There is an issue I want to talk about regarding the turn order feature. When adding friends and foes, it should be modular. Likely with a checkbox for adding a friend and one for adding a foe, separate from the currently available modes. That way you can add friends and foes to any distinct turn order configuration (eg myth and bone), as well as play with only a friend/only a foe.

@on3iro
Copy link
Owner

on3iro commented Nov 18, 2024

@deusabianca I don't plan on ever owning the new content and am completely out of the loop regarding new rules etc. I also don't have time to work on new features. Do you think that you could make these changes to the turn order feature? Else we could create a separate issue for this with the help wanted label. Though I would not be too optimistic that anyone will build this.

@Torgen
Copy link
Contributor

Torgen commented Dec 2, 2024

My friend has the wave 8 content and has lent it to me so I can transcribe it into the app. I can also implement the friend and foe cards in the turn order.

@on3iro
Copy link
Owner

on3iro commented Dec 2, 2024

@Torgen that's awesome! Note that @deusabianca already created a PR for one of the mini expansions: #526 - i'll try to review this asap.

Maybe you two could split the content somewhat, such that you wouldn't have to type most of the main content all by yourself @Torgen / @deusabianca ? :)

@Torgen
Copy link
Contributor

Torgen commented Dec 8, 2024

#529 means this is done?

@on3iro on3iro closed this as completed Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants