Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update emojilib to v3 #132

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented May 18, 2023

Bumps emojilib from the older v2 version we're on to its latest v3.

Note that this contains quite a few changes in how emojis are listed. See https://github.com/omnidan/node-emoji/pull/132/files#r1197993734

Fixes #129. Fixes #131.


return results
}),
]
Copy link
Collaborator Author

@JoshuaKGoldberg JoshuaKGoldberg May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few explicit handlers (e.g. :mexico: is no longer an alias of :flag_mexico:). Other changes are causing more test failures. I don't know what to do here - do we maintain explicit backwards compatibility? File issues on emojilib? Accept breaking changes? 😬

cc @omnidan, I don't know what to do 😄

Copy link
Collaborator Author

@JoshuaKGoldberg JoshuaKGoldberg May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked on Discord: I'm going to add compatibility helpers for the old aliases like this one. That way this isn't a breaking change for users in the sense of dropping emoji name support. Edit: there are a lot of changes 😞 so a compatibility layer would be quite large to write. Never mind on that.

I'll also look into whether we should file any issues on emojilib. muan/emojilib#178 indicated intentionally removing some aliases.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm waiting on #112 / muan/emojilib#194)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! How is the status of this??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHoooo yeah how is the status...

  1. emojilib v3 had a bunch of changes to its keywords - to the point where node-emoji can't directly transition.
  2. I pinged the maintainer (muan) and was added as a collaborator there a few weeks ago.
  3. What I want to do next is make a comparison of keywords: what exists in unicode, common operating systems, common messaging apps, GitHub, etc. (beyond what muan actually asked for)
  4. I haven't found a good tracking table yet that has all that info
    • I sent a request to get access the invite-only Emojipedia API a day or two ago but haven't heard back yet

So there is progress being made, just... slow progress.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello beautiful humans, I love what you did with this lib and thank you for providing this library for developer like me to build on top of it, is there a way we can get this fix merged? I desprately need some emojis which are missing from your lib. Maybe we can add a .extend(":emoji-code","✅") function, just in case some emojis are missing, developer can update it and make it searchable across project?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a .extend(":emoji-code","✅") function

Oh! I like that idea standalone - could you file a new issue for that please? Let's track it separately so we can maybe get it in much sooner!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #144 :)

@pimjansen
Copy link

pimjansen commented Aug 1, 2024

This is so outdated. Is anyone still working on getting this merged or should we look for alternative? I'd like my user to type :D or :) which is not possible with this lib only in v3.

I see that there is mostly discussion on breaking changes but why not just let it go and see this lib more as an easy integration for an emoji src instead

@yannickgloster
Copy link

Looks like it was finally updated upstream so we should be able to bump to 3.X
muan/emojilib#226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Waiting for something else to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emojify() misses some emojis in V2 Bump emojilib to 3.X
5 participants