Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏴󠁧󠁢󠁥󠁮󠁧󠁿 🏴󠁧󠁢󠁳󠁣󠁴󠁿 england, scotland flags are not decoded even if their unicode values are mentioned in emojifile.js #106

Closed
Dhanraj-Naik opened this issue Mar 6, 2021 · 2 comments

Comments

@Dhanraj-Naik
Copy link

Hi
i am getting :waving_black_flag: when i add flag-england(🏴󠁧󠁢󠁥󠁮󠁧󠁿) or flag-scotland(🏴󠁧󠁢󠁳󠁣󠁴󠁿) or flag-wales(🏴󠁧󠁢󠁷󠁬󠁳󠁿) when i unemojify.
so again when i do emojify that :waving_black_flag: string, i am getting following output:
OUTPUT: 🏴?????????????????????????.

Why 🏴󠁧󠁢󠁥󠁮󠁧󠁿 🏴󠁧󠁢󠁳󠁣󠁴󠁿 flags are not decoded even if their codes are mentioned in emojifile.js?

Platform: React Native 63.0.+
Node.js v14.15.5
"node-emoji": "1.10.0".

Any suggestions?

@Dhanraj-Naik
Copy link
Author

i think the issue is with lodash toArray method here which is used inside emoji.js file to unemojify string to array.
Screenshot 2021-03-06 at 3 42 17 PM

That is:
_.toArray('🏴󠁧󠁢󠁥󠁮󠁧󠁿');
outputs as:
["🏴", "󠁧", "󠁢", "󠁥", "󠁮", "󠁧", "󠁿"]

Any help here will be much appreciated.
Thank you

ghost referenced this issue in esmBot/esmBot Dec 14, 2021
@JoshuaKGoldberg
Copy link
Collaborator

👋 Looks like this behavior was changed -potentially fixed?- when v2 switched to using emojilib (#113):

import * as emoji from "node-emoji";

console.log(emoji.unemojify("🏴󠁧󠁢󠁥󠁮󠁧󠁿"));
:england:

Note that we're also looking at upgrading to emojilib v3 (#132). So I'll close this issue out as no longer relevant. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants