Rework dialog boxes to use modern components and sizing #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialog boxes were previously very hardcoded. This PR makes them use the more modern container widgets and text rendering so they are more flexible with regard to their contents. This also improves the menu widget layout behavior and adds support for centered horizontal menus, which are used for the dialog buttons. Dialog boxes are now made up of a menu containing a textlabel, for the dialog text, then a horizontal, centered menu that holds the dialog buttons.
|
Don't merge this yet, it breaks the mainmenu somewhat. |
|
Ok, this should be good now. |
katajakasa
reviewed
Oct 12, 2024
katajakasa
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialog boxes were previously very hardcoded. This PR makes them use the more modern container widgets and text rendering so they are more flexible with regard to their contents.
This also improves the menu widget layout behavior and adds support for centered horizontal menus, which are used for the dialog buttons.
Dialog boxes are now made up of a menu containing a textlabel, for the dialog text, then a horizontal, centered menu that holds the dialog buttons.