chore: Adds go vet analyzers in CI

.golangci.yml

@@ -169,13 +169,8 @@ linters-settings:
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
           - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
-    # enable or disable analyzers by name
-    enable:
-      - atomicalign
-    enable-all: false
-    disable:
-      - shadow
-    disable-all: false
+    # enable all analyzers
+    enable-all: true
   depguard:
     list-type: blacklist
     include-go-root: false

context/context.go

@@ -55,10 +55,10 @@ type NSSFContext struct {
 	RegisterIPv4 string
 	// HttpIpv6Address string
 	BindingIPv4       string
-	SBIPort           int
 	NfService         map[models.ServiceName]models.NfService
 	NrfUri            string
 	SupportedPlmnList []models.PlmnId
+	SBIPort           int
 }
 
 // Initialize NSSF context with configuration factory

factory/config.go

@@ -26,8 +26,8 @@ const (
 type Config struct {
 	Info          *Info               `yaml:"info"`
 	Configuration *Configuration      `yaml:"configuration"`
-	Subscriptions []Subscription      `yaml:"subscriptions,omitempty"`
 	Logger        *logger_util.Logger `yaml:"logger"`
+	Subscriptions []Subscription      `yaml:"subscriptions,omitempty"`
 }
 
 type Info struct {
@@ -100,8 +100,8 @@ type MappingFromPlmnConfig struct {
 }
 
 type Subscription struct {
-	SubscriptionId   string                                  `yaml:"subscriptionId"`
 	SubscriptionData *models.NssfEventSubscriptionCreateData `yaml:"subscriptionData"`
+	SubscriptionId   string                                  `yaml:"subscriptionId"`
 }
 
 var ConfigPodTrigger chan bool

producer/nssaiavailability_store.go

@@ -39,7 +39,7 @@ func NSSAIAvailabilityDeleteProcedure(nfId string) *models.ProblemDetails {
 		}
 	}
 
-	*problemDetails = models.ProblemDetails{
+	problemDetails = &models.ProblemDetails{
 		Title:  util.UNSUPPORTED_RESOURCE,
 		Status: http.StatusNotFound,
 		Detail: fmt.Sprintf("AMF ID '%s' does not exist", nfId),
@@ -87,7 +87,7 @@ func NSSAIAvailabilityPatchProcedure(nssaiAvailabilityUpdateInfo plugin.PatchDoc
 	}
 	factory.ConfigLock.RUnlock()
 	if !hitAmf {
-		*problemDetails = models.ProblemDetails{
+		problemDetails = &models.ProblemDetails{
 			Title:  util.UNSUPPORTED_RESOURCE,
 			Status: http.StatusNotFound,
 			Detail: fmt.Sprintf("AMF ID '%s' does not exist", nfId),
@@ -114,7 +114,7 @@ func NSSAIAvailabilityPatchProcedure(nssaiAvailabilityUpdateInfo plugin.PatchDoc
 
 	patch, err := jsonpatch.DecodePatch(patchJSON)
 	if err != nil {
-		*problemDetails = models.ProblemDetails{
+		problemDetails = &models.ProblemDetails{
 			Title:  util.MALFORMED_REQUEST,
 			Status: http.StatusBadRequest,
 			Detail: err.Error(),
@@ -124,7 +124,7 @@ func NSSAIAvailabilityPatchProcedure(nssaiAvailabilityUpdateInfo plugin.PatchDoc
 
 	modified, err := patch.Apply(original)
 	if err != nil {
-		*problemDetails = models.ProblemDetails{
+		problemDetails = &models.ProblemDetails{
 			Title:  util.INVALID_REQUEST,
 			Status: http.StatusConflict,
 			Detail: err.Error(),
@@ -136,7 +136,7 @@ func NSSAIAvailabilityPatchProcedure(nssaiAvailabilityUpdateInfo plugin.PatchDoc
 	err = json.Unmarshal(modified, &factory.NssfConfig.Configuration.AmfList[amfIdx].SupportedNssaiAvailabilityData)
 	factory.ConfigLock.Unlock()
 	if err != nil {
-		*problemDetails = models.ProblemDetails{
+		problemDetails = &models.ProblemDetails{
 			Title:  util.INVALID_REQUEST,
 			Status: http.StatusBadRequest,
 			Detail: err.Error(),

producer/nssaiavailability_subscription.go

@@ -60,7 +60,7 @@ func NSSAIAvailabilityPostProcedure(createData models.NssfEventSubscriptionCreat
 	if err != nil {
 		logger.Nssaiavailability.Warnf(err.Error())
 
-		*problemDetails = models.ProblemDetails{
+		problemDetails = &models.ProblemDetails{
 			Title:  util.UNSUPPORTED_RESOURCE,
 			Status: http.StatusNotFound,
 			Detail: err.Error(),
@@ -99,7 +99,7 @@ func NSSAIAvailabilityUnsubscribeProcedure(subscriptionId string) *models.Proble
 	}
 
 	// No specific subscription ID exists
-	*problemDetails = models.ProblemDetails{
+	problemDetails = &models.ProblemDetails{
 		Title:  util.UNSUPPORTED_RESOURCE,
 		Status: http.StatusNotFound,
 		Detail: fmt.Sprintf("Subscription ID '%s' is not available", subscriptionId),

producer/subscription_id_document.go

@@ -19,7 +19,6 @@ import (
 
 	"github.com/omec-project/http_wrapper"
 	"github.com/omec-project/nssf/logger"
-	"github.com/omec-project/openapi/models"
 )
 
 // HandleNSSAIAvailabilityUnsubscribe - Deletes an already existing NSSAI availability notification subscription
@@ -32,12 +31,6 @@ func HandleNSSAIAvailabilityUnsubscribe(request *http_wrapper.Request) *http_wra
 
 	if problemDetails == nil {
 		return http_wrapper.NewResponse(http.StatusNoContent, nil, nil)
-	} else if problemDetails != nil {
-		return http_wrapper.NewResponse(int(problemDetails.Status), nil, problemDetails)
 	}
-	problemDetails = &models.ProblemDetails{
-		Status: http.StatusForbidden,
-		Cause:  "UNSPECIFIED",
-	}
-	return http_wrapper.NewResponse(http.StatusForbidden, nil, problemDetails)
+	return http_wrapper.NewResponse(int(problemDetails.Status), nil, problemDetails)
 }

test/param.go

@@ -26,11 +26,9 @@ type TestingUtil struct {
 }
 
 type TestingNsselection struct {
-	ConfigFile string
-
 	GenerateNonRoamingQueryParameter func() NsselectionQueryParameter
-
-	GenerateRoamingQueryParameter func() NsselectionQueryParameter
+	GenerateRoamingQueryParameter    func() NsselectionQueryParameter
+	ConfigFile                       string
 }
 
 type TestingNssaiavailability struct {