-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds go vet analyzers in CI #47
chore: Adds go vet analyzers in CI #47
Conversation
Signed-off-by: Patricia Reinoso <[email protected]>
Signed-off-by: Patricia Reinoso <[email protected]>
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you run an end-to-end test using AiaB, OnRamp or other system to make sure that the proposed changes (order of the fields, etc.) do not break anything?
Signed-off-by: Patricia Reinoso <[email protected]>
Co-authored-by: gab-arrobo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (tested changes with AiaB)
Enable all go vet analyzers in CI
Fixes
fieldalignment
andnilness
analyzer checks