Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage instructions in readme #28
Usage instructions in readme #28
Changes from 9 commits
9227c3f
a6e27e3
b516152
35242d2
2c3563b
f9a6e8a
521612e
8c18030
c3b28f3
7653551
bc58fdd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have an example of in what form does the ROI have to be offered in order to be populated ? @manics @sbesson ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this feature is largely a legacy feature which came together with the decoupling of the
metadata
plugin:omero_metadata
plugin currently simply imports this API and exposes it as a subcommandpopulate_roi
primarily supports ROIs generated by a few proprietary HCS file formats (Flex, MIAS, InCell)Open for discussion but my feeling is we should rather keep this plugin focused its annotation functionalities (tables, maps, original metadata). As part of the IDR work, @manics started work on https://github.com/ome/omero-rois which might be a much more appropriate location for this particular API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about deprecate
populateroi
(I've never figured out how it works or where it gets the ROIs from) and avoid mentioning it anywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove
populateroi
. There's also therois
command. Not sure what that does either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@will-moore the rois command enables to delete rois in that container and list them in form ROI:ID. I think it is useful