Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage instructions in readme #28

Merged
merged 11 commits into from
Jul 12, 2019

Conversation

will-moore
Copy link
Member

Added usage instructions to the README, particularly for populate command.

See it staged at https://github.com/will-moore/omero-metadata/tree/usage_instructions_in_README

README.rst Show resolved Hide resolved
@will-moore
Copy link
Member Author

NB: as noted by @manics and discussed with @pwalczysko, the behaviour of Plate and Well columns is different from Dataset Name and Image Name as documented at #29

Just added more info about renaming of Well -> Well Name etc.

@will-moore will-moore force-pushed the usage_instructions_in_README branch from 04d2acd to c3b28f3 Compare July 10, 2019 14:28
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@pwalczysko
Copy link
Member

README.rst Show resolved Hide resolved
README.rst Outdated
- ``original``: Print the original metadata in ini format
- ``pixelsize``: Set physical pixel size
- ``populate``: Add metadata (bulk-annotations) to an object (see below)
- ``populateroi``: Add ROIs to an object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an example of in what form does the ROI have to be offered in order to be populated ? @manics @sbesson ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature is largely a legacy feature which came together with the decoupling of the metadata plugin:

  • the ROI population API is still in upstream OMERO.py -see omero.util.populate_roi
  • the omero_metadata plugin currently simply imports this API and exposes it as a subcommand
  • in terms of functionality, the current version of populate_roi primarily supports ROIs generated by a few proprietary HCS file formats (Flex, MIAS, InCell)

Open for discussion but my feeling is we should rather keep this plugin focused its annotation functionalities (tables, maps, original metadata). As part of the IDR work, @manics started work on https://github.com/ome/omero-rois which might be a much more appropriate location for this particular API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about deprecate populateroi (I've never figured out how it works or where it gets the ROIs from) and avoid mentioning it anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove populateroi. There's also the rois command. Not sure what that does either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@will-moore the rois command enables to delete rois in that container and list them in form ROI:ID. I think it is useful

@pwalczysko
Copy link
Member

reads fine now. Ready to merge FMPOV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants