Fix Less comparator and IsNegativeThan implementations #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Fix Less operator implementation to handle equality case - Add IsNegativeThan implementation - Update CMakeLists.txt for new tests
- Change return type from bool to Valuable - Update implementation to return Integer(0) for true and Integer(1) for false - Add override keyword to declaration
- Replace test() macro with proper CMake test configuration - Add explicit dependencies and linking - Configure test targets correctly
- Change logic to logic1 in test target dependencies - Fix library linking for test executables
- Add missing Variable.h include to fix incomplete type errors - Required for proper STL container usage with Variable class
- Replace BOOST_CHECK with BOOST_CHECK_EQUAL - Compare with Integer(0) and Integer(1) instead of boolean values
devin-ai-integration
bot
force-pushed
the
fix/less-comparator-clean
branch
from
b00ea13
to
ccfab47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Less_comparator_test failures by correcting IsNegativeThan() and Less() implementations.
Changes
Testing
Note: The Windows build failure is unrelated to these changes (Boost GIL warnings in image_codec_test).
Link to Devin run: https://preview.devin.ai/devin/0ec7d397e84b48a9b87c859843b903b2