Fix IsNegativeThan implementation to correctly handle negative number…

… comparisons
ohhmm · Nov 13, 2024 · b00ea13 · b00ea13
1 parent 477f1f6
commit b00ea13
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/omnn/math/Integer.cpp b/omnn/math/Integer.cpp
@@ -746,15 +746,15 @@ namespace math {
 
     Valuable Integer::IsNegativeThan(const Valuable& other) const
     {
-        if (arbitrary >= 0)
-            return Integer(1);
-
-        if (other.IsInt())
-            return arbitrary == -other.ca() ? Integer(0) : Integer(1);
-        else if (other.IsFraction())
-            return Integer(1);
-        else
-            return Integer(1);
+        if (other.IsInt()) {
+            return (arbitrary < 0 && arbitrary == -other.ca()) ? Integer(1) : Integer(0);
+        }
+        else if (other.IsFraction()) {
+            return Integer(0);
+        }
+        else {
+            return Integer(0);
+        }
     }
 
     std::ostream& Integer::print(std::ostream& out) const