Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Up: Upgrade Eslint version to v9 #10180

Merged
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/e2e/login_spec/loginpage.cy.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { LoginPage } from "../../pageObject/auth/LoginPage";
import { LoginPage } from "pageObject/auth/LoginPage";

AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
describe("Login Page", () => {
const loginPage = new LoginPage();
Expand Down
1 change: 1 addition & 0 deletions cypress/support/commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Cypress.Commands.add("getAttached", (selector: string) => {
$el = getElement(Cypress.$($d));
// Ensure $el is an HTMLElement before checking if it is detached
if ($el.length && $el[0] instanceof HTMLElement) {
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
AdityaJ2305 marked this conversation as resolved.
Show resolved Hide resolved
expect(Cypress.dom.isDetached($el[0])).to.be.false; // Access the first HTMLElement
} else {
throw new Error("Element is not an HTMLElement or is detached.");
Expand Down
1 change: 1 addition & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export default [
...globals.node,
React: true,
},
parser: tsParser,
parserOptions: {
ecmaFeatures: {
jsx: true,
Expand Down
2 changes: 1 addition & 1 deletion plugins/treeShakeCareIcons.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export function treeShakeCareIcons(
// Generates a map of used icon names to their paths from UniconPaths.json, including any whitelisted icons.
function getTreeShakenUniconPaths() {
const usedIcons = [...getAllUsedIconNames(), ...options.iconWhitelist];
const treeshakenCareIconPaths = {};
const treeshakenCareIconPaths: { [key: string]: string } = {};

for (const iconName of usedIcons) {
const path = allUniconPaths[iconName];
Expand Down
1 change: 0 additions & 1 deletion scripts/sort-locales.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// eslint-disable-next-line @typescript-eslint/no-var-requires
const fs = require("fs");

const file = "public/locale/en.json";
Expand Down
1 change: 0 additions & 1 deletion tailwind.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-var-requires */
const colors = require("tailwindcss/colors");

const secondary = {
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
},
"typeRoots": ["./node_modules/@types", "./src/remote-modules.d.ts"]
},
"include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.d.ts", "care.config.ts"],
"include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.d.ts", "care.config.ts","scripts/**/*.ts","cypress.config.ts","plugins/**/*.ts"],
"exclude": ["src/**/*.gen.tsx"]
}
Loading