[v1.20.x] prov/shm: Fix coverity issue about resource leak

Sock variable handle goes out of scope and leaks the handle. This cleans it up properly. Signed-off-by: Zach Dworkin <[email protected]> (cherry picked from commit e6bc224)
ofiwg · Jan 20, 2024 · 8286157 · 8286157
1 parent c10b680
commit 8286157
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/prov/shm/src/smr_ep.c b/prov/shm/src/smr_ep.c
@@ -1037,8 +1037,10 @@ static void *smr_start_listener(void *args)
 					ep->sock_info->peers[id].device_fds =
 						calloc(ep->sock_info->nfds,
 							sizeof(*ep->sock_info->peers[id].device_fds));
-					if (!ep->sock_info->peers[id].device_fds)
+					if (!ep->sock_info->peers[id].device_fds) {
+						close(sock);
 						goto out;
+					}
 				}
 				memcpy(ep->sock_info->peers[id].device_fds,
 				       peer_fds, sizeof(*peer_fds) *