[v1.20.x] util: Fix coverity issue about missing lock

All write accesses to `wait->signal` are protected by the lock. The read access should be protected, too. Signed-off-by: Jianxin Xiong <[email protected]> (cherry picked from commit e16f28a)
ofiwg · Jan 20, 2024 · c10b680 · c10b680
1 parent 555760a
commit c10b680
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/prov/util/src/util_wait.c b/prov/util/src/util_wait.c
@@ -599,7 +599,16 @@ static int util_wait_yield_run(struct fid_wait *wait_fid, int timeout)
 	wait = container_of(wait_fid, struct util_wait_yield, util_wait.wait_fid);
 	endtime = ofi_timeout_time(timeout);
 
-	while (!wait->signal) {
+	while (1) {
+		int signaled;
+
+		ofi_mutex_lock(&wait->signal_lock);
+		signaled = wait->signal;
+		ofi_mutex_unlock(&wait->signal_lock);
+
+		if (signaled)
+			break;
+
 		if (ofi_adjust_timeout(endtime, &timeout))
 			return -FI_ETIMEDOUT;
 		ofi_mutex_lock(&wait->util_wait.lock);