Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slide parts (and mark private methods) #11

Merged
merged 20 commits into from
Jan 11, 2024
Merged

Add slide parts (and mark private methods) #11

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b5f8def
Add slide parts (and mark private methods)
mirisuzanne Dec 28, 2023
4bf28c0
Clarify sample slide in demo
mirisuzanne Jan 3, 2024
a82b69b
Merge branch 'main' into parts
mirisuzanne Jan 3, 2024
42a562a
Merge in changes from #10
mirisuzanne Jan 4, 2024
fc2ed03
wip - color modes
stacyk Jan 4, 2024
5dea08d
revert previous commit
stacyk Jan 5, 2024
ff5053e
Remove notes show/hide, and add script view
mirisuzanne Jan 5, 2024
e83e3cb
Remove view-specific events
mirisuzanne Jan 5, 2024
c92f022
Set aria-current for active slides, and clarify part attributes
mirisuzanne Jan 6, 2024
20b8e36
add very basic styles for script view
stacyk Jan 6, 2024
26f76dd
styles for slide-item in script view
stacyk Jan 6, 2024
504bdef
Privatizion
jamesnw Jan 8, 2024
f5cdd61
Move attribute state to getters
jamesnw Jan 8, 2024
fb1b1f6
Static appendShadowTemplate
jamesnw Jan 9, 2024
c375e08
Make slideNotes and slideCanvas private
jamesnw Jan 9, 2024
14de103
Add CSS to usage examples, remove version
jamesnw Jan 9, 2024
66852dc
Make script view better for smaller screens
stacyk Jan 10, 2024
15a6c55
order by alpha
stacyk Jan 11, 2024
a4e2519
adjust solo grid rows for testing, still need slide height though
stacyk Jan 11, 2024
baa85a5
Stretch slide canvas to fill container in solo view
mirisuzanne Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions slide-deck.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
slide-deck {
--color-dark: #1e1e1e;
--color-light: white;
--gap: clamp(8px, 0.25em + 1vw, 16px);
color: var(--text-color);
container: slide-deck / inline-size;
display: grid;
min-height: 100vh;

&[slide-view=grid] {
--slide-ratio: 16/9;
Expand All @@ -18,13 +22,20 @@ slide-deck {

&[blank-slide]::after {
content: '';
background-color: var(--blank-color, black);
background-color: var(--blank-color);
position: absolute;
inset: 0;
z-index: -1;
}

&[blank-slide=black] {
--blank-color: var(--color-dark);
--text-color: var(--color-light);
}

&[blank-slide=white] {
--blank-color: white;
--blank-color: var(--color-light);
--text-color: var(--color-dark);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stacy I think the purpose of the blank slide is hiding what's on the screen - it's a way to temporarily 'pause' the presentation, either with a white or black overlay. Moving the overlay behind the text, and then adding text contrast kinda defeats the purpose, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirisuzanne that was not clear to me at all, and for some reason the "blank" in the name made me think it was more like we are starting with a blank slate, a default slide instead of the more obvious intention of "this should not show anything and it should be blank or empty" 🤦🏻‍♀️ . I don't really know what design issues need to be solved in which PRs/Issues right now, and what is a bug vs what isn't yet ready so I feel like I am overthinking things and not being very helpful yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I think right now the biggest design issues are the comment above (UX questions about how this should work - what views should be available) and actually designing the slide templates over on the workshop repo. It's ok for design to be pretty minimal in this repo for now.

}

[slide-canvas] {
Expand Down