generated from daviddarnes/component-template
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slide parts (and mark private methods) #11
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b5f8def
Add slide parts (and mark private methods)
mirisuzanne 4bf28c0
Clarify sample slide in demo
mirisuzanne a82b69b
Merge branch 'main' into parts
mirisuzanne 42a562a
Merge in changes from #10
mirisuzanne fc2ed03
wip - color modes
stacyk 5dea08d
revert previous commit
stacyk ff5053e
Remove notes show/hide, and add script view
mirisuzanne e83e3cb
Remove view-specific events
mirisuzanne c92f022
Set aria-current for active slides, and clarify part attributes
mirisuzanne 20b8e36
add very basic styles for script view
stacyk 26f76dd
styles for slide-item in script view
stacyk 504bdef
Privatizion
jamesnw f5cdd61
Move attribute state to getters
jamesnw fb1b1f6
Static appendShadowTemplate
jamesnw c375e08
Make slideNotes and slideCanvas private
jamesnw 14de103
Add CSS to usage examples, remove version
jamesnw 66852dc
Make script view better for smaller screens
stacyk 15a6c55
order by alpha
stacyk a4e2519
adjust solo grid rows for testing, still need slide height though
stacyk baa85a5
Stretch slide canvas to fill container in solo view
mirisuzanne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this looks like more space than is needed? I think a faint boarder would be more useful than space? This feels like a view where context is more useful than whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirisuzanne how much space are you seeing? I see like, less than pinky width on active slides?
Official measurement device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stacyk Oh oh oh, it's the
5em
row gap that's real large for me. Sorry. I think that could be more like a hairline and something closer to the column gap.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started playing with a hairline (it was a little finicky because of the slide item with container and with only canvas are different sizes), but then I wondered if was more than a layout thing that I should apply in a custom theme instead of the default styles in this tool. But I can play with it more in this tool to see if I can get it just right.