Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: add repro for gh11375 #11376

Merged
merged 1 commit into from
Jan 24, 2025
Merged

pkg: add repro for gh11375 #11376

merged 1 commit into from
Jan 24, 2025

Conversation

gridbugs
Copy link
Collaborator

Repro for #11375

@gridbugs
pkg: add repro for gh11375
d3a08bf 
Signed-off-by: Stephen Sherratt <[email protected]>
@gridbugs gridbugs mentioned this pull request Jan 24, 2025
Open
@Leonidas-from-XIV Leonidas-from-XIV merged commit 2445e90 into ocaml:main Jan 24, 2025
26 of 27 checks passed
@rgrinberg
Copy link
Member

Isn't this just a clone of https://github.com/gridbugs/dune/blob/d3a08bfc8953a9a377edd71ea5891d61cc6c4953/test/blackbox-tests/test-cases/pkg/ignore-lock-release.t?

@Leonidas-from-XIV
Copy link
Collaborator

Good point, it's very similar to that. Might need to revert.

However, I think we should determine whether ignoring lockdirs should be the behavior of --release or -p.

@rgrinberg
Copy link
Member

My test also uses --release. I think it should be equivalent for both. -p is just --release with --only-packages set.

Leonidas-from-XIV added a commit that referenced this pull request Jan 24, 2025
@Leonidas-from-XIV
Revert "pkg: add repro for gh11375 (#11376)"
0eb6c6b 
This reverts commit 2445e90.
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Jan 24, 2025
Merged
Leonidas-from-XIV added a commit to Leonidas-from-XIV/dune that referenced this pull request Jan 24, 2025
@Leonidas-from-XIV
Revert "pkg: add repro for gh11375 (ocaml#11376)"
e9af9d4 
This reverts commit 2445e90.

Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV added a commit that referenced this pull request Jan 24, 2025
@Leonidas-from-XIV
Revert "pkg: add repro for gh11375 (#11376)" (#11379)
39c9727 
This reverts commit 2445e90.

Signed-off-by: Marek Kubica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

@maiste maiste Awaiting requested review from maiste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gridbugs @rgrinberg @Leonidas-from-XIV