Revert "pkg: add repro for gh11375" #11379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. As you all probably know by now, duplicate tests plague our test suite and it's very hard to find a test for a particular behavior. Sometime, I do a "fix" to check if any test is affected writing the actual test. Then I just reverse the order of the test and the fix for submission. |
This reverts commit 2445e90. Signed-off-by: Marek Kubica <[email protected]>
Leonidas-from-XIV
force-pushed
the
revert-11376-repro-11375
branch
from
0eb6c6b to
e9af9d4
Compare
ElectreAAS
pushed a commit
to ElectreAAS/dune
that referenced
this pull request
Jan 27, 2025
This reverts commit 2445e90. Signed-off-by: Marek Kubica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11376
As @rgrinberg points out, we already have a test for this so to keep test run duration manageable I'd suggest reverting the addition of the new test.