-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cmm functions to be more generic over operand width #3404
Conversation
Selection Change CheckThis PR modifies the original selection pass (targeting Mach). |
This PR refactors cmm_helpers in preparation for unboxed 8 and 16-bit integers to be added to the compiler. |
Parser Change ChecklistThis PR modifies the parser. Please check that the following tests are updated:
This test should have examples of every new bit of syntax you are adding. Feel free to just check the box if your PR does not actually change the syntax (because it is refactoring the parser, say). |
d1acc48
to
abcd725
Compare
16f1b23
to
443a81c
Compare
34a5e6a
to
6392eea
Compare
…ve unboxed integers of different sizes
443a81c
to
2f5d60b
Compare
6392eea
to
e5c7499
Compare
338f838
to
e0b8691
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good overall, modulo the few changes which change/allow more things in mixed blocks, and which don't seem to be part of the refactor (and which would need more in-depth review to make sure the code is correct and that the rest of the code dealing with them is correct for these new values).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; some comments on comments
No description provided.