Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that we correctly sign-extend values that we write #3638

Open
jvanburen opened this issue Feb 27, 2025 · 0 comments
Open

check that we correctly sign-extend values that we write #3638

jvanburen opened this issue Feb 27, 2025 · 0 comments

Comments

@jvanburen
Copy link
Contributor

          Not specific to this PR, but I noticed this does not write sign-extended int32#s into mixed blocks. Flambda2 tries to make sure the full content of blocks is deterministic (e.g. [in closures](https://github.com/ocaml-flambda/flambda-backend/blob/main/middle_end/flambda2/to_cmm/to_cmm_shared.ml#L398)), so I think [this code](https://github.com/ocaml-flambda/flambda-backend/blob/main/middle_end/flambda2/to_cmm/to_cmm_primitive.ml#L188) should probably be changed. But maybe this can never be used on static blocks so we don't care---we should check with the flambda2 devs.

Originally posted by @TheNumbat in #3404 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant