Introduce Pickles drawio diagram #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
volhovm
force-pushed
the
volhovm/add-pickles-drawio-diagram
branch
from
5e5d17d
to
6bed969
Compare
mrmr1993
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Comments about diagrams:
MFNS (digest?) -- ignored/bound by SE- `(digest?) is false
- in general, the MFNS names seem unhelpful, I would prefer that they were expanded
run application logic of previous statementsshould berun application logic of statementAssert equal ?????should becomputed from unpacked preimage when verifying
|
@mrmr1993 Ready for another review pass, all addressed. |
mrmr1993
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the pickles structure diagram, intended to be a part of the mina book.