Vinegar RFC #42
Merged
Vinegar RFC #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmr1993
requested changes
Feb 6, 2024
There was a problem hiding this comment.
Broadly looks good, apart from a few structural comments. There are a few issues though:
- this doesn't follow the issue template, and essentially only addresses the
Detailed designsection thereof; - this doesn't have an RFC number (although I can quickly allocate one when this is ready to merge).
|
@mrmr1993 Thank you for the feedback.
|
volhovm
force-pushed
the
volhovm/vinegar-rfc
branch
from
05581a8
to
4790775
Compare
volhovm
force-pushed
the
volhovm/vinegar-rfc
branch
from
65676a3
to
4d4df39
Compare
volhovm
commented
Feb 7, 2024
| @@ -23,7 +23,7 @@ In general: | |||
|
|
|||
| * Be specific. This document is meant to share intent to your colleagues. Share what you believe you will actually do. | |||
| * Be decisive. No maybes. Any uncertainty can be captured in the unresolved questions section at the end. | |||
| * Provide design contex so that we can align on and commit to a technical design. | |||
There was a problem hiding this comment.
For the reviewers: changes in 001-template.md are orthogonal, but very cosmetic, and it would be very hard to merge a separate PR because it needs a lot of approvals. So I want to add it here. It's a separate commit, so can be reverted individually if needed.
mrmr1993
approved these changes
Feb 14, 2024
|
@mrmr1993 all addressed, assigned number 12 (next sequential after zkapps), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the RFC describing vinegar, the compatibility layer for pickles.
PRs merging documentation for pickles created when sketching this RFC: