Fix failed jobs when produces for a listener closure (#83)

nuwber · Jan 25, 2022 · e34aa7e · e34aa7e
1 parent 350564f
commit e34aa7e
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/Queue/Jobs/Job.php b/src/Queue/Jobs/Job.php
@@ -71,7 +71,10 @@ public function failed($e): void
     {
         $this->markAsFailed();
 
-        if (method_exists($listener = $this->resolve($this->listenerClass), 'failed')) {
+        if (
+            $this->listenerClass !== \Closure::class
+            && method_exists($listener = $this->resolve($this->listenerClass), 'failed')
+        ) {
             $listener->failed($this->payload(), $e);
         }
     }
@@ -113,7 +116,7 @@ public function displayName(): string
     {
         return $this->getName();
     }
-    
+
     /**
      * Get the timestamp indicating when the job should timeout.
      */

diff --git a/tests/Queue/Jobs/JobTest.php b/tests/Queue/Jobs/JobTest.php
@@ -97,6 +97,25 @@ public function testFailing()
         self::assertEquals($message->getBody(), $listener->payload);
     }
 
+    public function testFailingClosure()
+    {
+        $exception = new \Exception("Exception in `fire` method");
+
+        $app = new Container();
+        $message = $this->getMessage();
+
+        $queueManager = m::spy(Manager::class);
+
+        $job = new Job($app, $queueManager, $message,
+            'trim',
+            \Closure::class
+        );
+
+        $job->failed($exception);
+
+        self::assertTrue($job->hasFailed());
+    }
+
     public function testGetJobId()
     {
         $job = $this->getJob();