Allow closure listeners (#81)

* Allow clouse listeners * Add documentation Add test to avoid regression * Avoid makeListener when you pass a closure * Refactor listener closure Co-authored-by: Alex Rubia <[email protected]>
nuwber · Dec 10, 2021 · 350564f · 350564f
1 parent d67d79a
commit 350564f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/readme.md b/readme.md
@@ -143,7 +143,8 @@ The `listen` property of `RabbitEventsServiceProvider` contains an array of all
 protected $listen = [
     'item.created' => [
         'App\Listeners\SendItemCreatedNotification',
-        'App\Listeners\ChangeUserRole',
+        'App\Listeners\ChangeUserRole@process',
+        function($payload) { Log::info('Item created', $payload); },
     ],
 ];
 ```

diff --git a/src/Dispatcher.php b/src/Dispatcher.php
@@ -39,6 +39,10 @@ public function listen($events, $listener = null): void
      */
     public function makeListener($listener, $wildcard = false): \Closure
     {
+        if ($listener instanceof \Closure) {
+            return $listener;
+        }
+
         return function ($event, $payload) use ($listener, $wildcard) {
             $throughMiddleware = $this->extractMiddleware($listener);
 

diff --git a/tests/DispatcherTest.php b/tests/DispatcherTest.php
@@ -39,9 +39,11 @@ public function testListen()
     public function testAddedClosureListeners()
     {
         $dispatcher = new Dispatcher();
+        $closure1 = function() {};
+        $closure2 = function() {};
 
-        $dispatcher->listen('item.event', function() {});
-        $dispatcher->listen('item.event', function() {});
+        $dispatcher->listen('item.event', $closure1);
+        $dispatcher->listen('item.event', $closure2);
 
         $listeners = $dispatcher->getListeners('item.event');
 
@@ -50,6 +52,10 @@ public function testAddedClosureListeners()
         self::assertEquals(['Closure'], array_keys($listeners));
 
         self::assertCount(2, $listeners['Closure']);
+
+        self::assertSame($closure1, $listeners['Closure'][0]);
+
+        self::assertSame($closure2, $listeners['Closure'][1]);
     }
 
     public function testCorrectWildcardHandling()