Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature completion for load/store. Merge atomic load/store into regular load/store. #564

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ARF1
Copy link
Contributor

@ARF1 ARF1 commented Mar 28, 2020

Completes implementations of load and store to support all features. Merges atomic load/store with regular load/store.

Fixes #450.

Incorporated PRs:

This builds on @ssikdar1's works in #559 where he merged the public api of atomic load/store into regular load/store.

Further commits make the following changes to @ssikdar1's work:

  • restore the deleted public api for atomic memory access and add deprecation warnings to builder.load_atomic() and builder.store_atomic()
  • merge LoadAtomicInstr with LoadInstr and StoreAtomicInstr with StoreAtomicInstr
  • support volatile flag for load/store
  • support sync_scope for atomic operations
  • document api additions & deprecation warnings for obsolete api

@ARF1 ARF1 force-pushed the wip/store_load_unification branch from 4e8afd1 to eb50231 Compare March 28, 2020 23:39
@ARF1
Copy link
Contributor Author

ARF1 commented Mar 28, 2020

@stuartarchibald This is ready for review. Thanks.

@ARF1 ARF1 changed the title Merge atomic into regular memory access & introduce volatile memory access Feature completion for load/store. Merge atomic load/store into regular load/store. Mar 29, 2020
@esc esc added this to the Version 0.35.0 milestone Aug 18, 2020
@stuartarchibald stuartarchibald removed this from the Version 0.35.0 milestone Nov 6, 2020
@esc esc added this to the Version 0.37.0 RC milestone Mar 22, 2021
@esc esc removed this from the Version 0.38.0 RC milestone Nov 22, 2021
@gmarkall gmarkall added this to the PR Backlog milestone Dec 21, 2021
@esc esc removed this from the PR Backlog milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge atomic load/store into regular load/store
6 participants