Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 2, python < 3.6, fix up, add flake8 #551

Merged
merged 11 commits into from
Mar 26, 2020

Conversation

stuartarchibald
Copy link
Contributor

@stuartarchibald stuartarchibald commented Feb 10, 2020

This PR:

  • Removes Python 2 specific code.
  • Removes Python <3.6 specific code.
  • Removes build/test infrastructure relating to the above.
  • Adds build/test infrastructure for Python 3.8
  • Adds flake8 checks to the source and enforces this in CI.
  • Fixes up the code base to be flake8 compliant.
  • Remove the AUTHORS file, this information is in git and the CHANGE_LOG
  • Fixes up the documentation (to some degree, LLVM 9 changes pending).

@stuartarchibald stuartarchibald added this to the Version 0.32.0 milestone Feb 10, 2020
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sklam
Copy link
Member

sklam commented Mar 23, 2020

/AzurePipelines run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@stuartarchibald
Copy link
Contributor Author

Anticipate CI fails will need #554 merging, and then a rerun.

@stuartarchibald
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@stuartarchibald
Copy link
Contributor Author

CI passed and @sklam approves. Marking for merge.

@ARF1
Copy link
Contributor

ARF1 commented Mar 28, 2020

@stuartarchibald @sklam Bumping to python <= 3.6 did not take for the AppVeyor:

C:\projects\llvmlite>conda create -n testenv -q -y python=3.8 cmake 
Fetching package metadata .......
Solving package specifications: .
Error: Package missing in current win-64 channels: 
  - python 3.8*

The result is that the AppVeyor CI build falls back to python 3.5 which means that any PR that uses python 3.6 features fails.

Would it be acceptable to set python to 3.6 instead of python 3.8 for AppVeyor? If yes, #565 does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants