-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python 2, python < 3.6, fix up, add flake8 #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Anticipate CI fails will need #554 merging, and then a rerun. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
CI passed and @sklam approves. Marking for merge. |
@stuartarchibald @sklam Bumping to python <= 3.6 did not take for the AppVeyor:
The result is that the AppVeyor CI build falls back to python 3.5 which means that any PR that uses python 3.6 features fails. Would it be acceptable to set python to 3.6 instead of python 3.8 for AppVeyor? If yes, #565 does this. |
This PR:
flake8
checks to the source and enforces this in CI.AUTHORS
file, this information is ingit
and theCHANGE_LOG