Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sysbuild Kconfig compliance #20403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

57300
Copy link
Contributor

@57300 57300 commented Feb 17, 2025

Clean up the sysbuild Kconfig tree and enable SysbuildKconfigBasic checks.

@57300 57300 requested review from a team as code owners February 17, 2025 11:04
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 17, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 17, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@4545832 nrfconnect/sdk-zephyr#2507 nrfconnect/sdk-zephyr#2507/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 17, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 34dfcb15810621671376871a98cdb3c1c5761796
zephyr: PR head: 04ebc957cab7d8f9e1051ce85611d98a87ab63ec

more details

sdk-nrf:

PR head: 34dfcb15810621671376871a98cdb3c1c5761796
merge base: c478fe44c719ecb6550590446b150720b14642e0
target head (main): c478fe44c719ecb6550590446b150720b14642e0
Diff

zephyr:

PR head: 04ebc957cab7d8f9e1051ce85611d98a87ab63ec
merge base: 454583293f36eca5bcdaaca8c65128945fe0c862
target head (main): 1bf500b0c51d8e04336b76d39437d408e3348956
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (17)
.github
│  ├── workflows
│  │  │ compliance.yml
sysbuild
│  ├── Kconfig.appcore
│  ├── Kconfig.cracen
│  ├── Kconfig.netcore
│  ├── Kconfig.secureboot
│  │ Kconfig.xip
west.yml
zephyr
│  ├── .github
│  │  ├── workflows
│  │  │  │ compliance.yml
│  ├── .gitignore
│  ├── drivers
│  │  ├── mbox
│  │  │  │ mbox_nrf_vevif_event_tx.c
│  ├── scripts
│  │  ├── ci
│  │  │  │ check_compliance.py
│  │  ├── dts
│  │  │  │ gen_driver_kconfig_dts.py
│  │  ├── pylib
│  │  │  ├── twister
│  │  │  │  ├── twisterlib
│  │  │  │  │  ├── platform.py
│  │  │  │  │  │ testplan.py
│  │  ├── tests
│  │  │  ├── twister
│  │  │  │  ├── test_platform.py
│  │  │  │  │ test_testplan.py
│  ├── share
│  │  ├── sysbuild
│  │  │  ├── images
│  │  │  │  ├── bootloader
│  │  │  │  │  │ Kconfig

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
  • ❌ Integration tests
    • ❌ test-sdk-audio
    • ❌ desktop52_verification
    • ❌ test-fw-nrfconnect-boot
    • ❌ test-fw-nrfconnect-apps
    • ❌ test_ble_nrf_config
    • ❌ test-fw-nrfconnect-ble_mesh
    • ❌ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • ❌ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_samples
    • ❌ test-fw-nrfconnect-nrf-iot_lwm2m
    • ❌ doc-internal
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-nrf_crypto
    • ❌ test-fw-nrfconnect-proprietary_esb
    • ❌ test-fw-nrfconnect-rpc
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-tfm
    • ❌ test-fw-nrfconnect-thread
    • ❌ test-fw-nrfconnect-zigbee
    • ❌ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
    • ❌ test-sdk-sidewalk
    • ❌ test-sdk-wifi
    • ❌ test-low-level
    • ❌ test-sdk-pmic-samples
    • ❌ test-sdk-mcuboot
    • ❌ test-sdk-dfu
    • ❌ test-fw-nrfconnect-ps
    • ❌ test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@57300 57300 force-pushed the kconfig-compliance branch from 7b5222c to 470383f Compare February 25, 2025 10:54
Copy link

After documentation is built, you will find the preview for this PR here.

@57300 57300 force-pushed the kconfig-compliance branch from 470383f to d55ac46 Compare February 26, 2025 07:25
Unused:
* APPCORE_IMAGE_BOARD

Undefined:
* APPCORE_REMOTE_BOARD_NAME
* EXTERNAL_CONFIGURED_APPCORE
* NETCORE_REMOTE_NRF5340_CPUNET
* SECURE_BOOT_PRIVATE_KEY_PROVIDED
* SECURE_BOOT_SIGNATURE_TYPE_ED25519

Pointless menuconfig:
* QSPI_XIP_SPLIT_IMAGE

Special case:
* NET_CORE_IMAGE_HCI_IPC

Signed-off-by: Grzegorz Swiderski <[email protected]>
Pull in the new checks added to sdk-zephyr. Of these, make sure that
only `SysbuildKconfigBasic` is enabled, just like with `KconfigBasic`.

Signed-off-by: Grzegorz Swiderski <[email protected]>
@57300 57300 force-pushed the kconfig-compliance branch from d55ac46 to 34dfcb1 Compare February 26, 2025 11:47
Copy link

You can find the documentation preview for this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants