merge test #296
Merged
merge test #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Robinlovelace
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Hi @wangzhao0217 looks good.
Can you move merge_test.qmd into the code/tests folder?
|
Done Robin.
…On Mon, 16 Oct 2023 at 10:42, Robin Lovelace ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @wangzhao0217 <https://github.com/wangzhao0217> looks good.
Can you move merge_test.qmd into the code/tests folder?
—
Reply to this email directly, view it on GitHub
<#296 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARZESTTI7XTMIXE3AU4RDITX7T6QVAVCNFSM6AAAAAA6BZ6RGOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNZZGU2TONRUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Robinlovelace
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Great job. This is good to go. Please merge and delete the old branch @wangzhao0217 🎉
|
And final step @wangzhao0217: deleting the branch. You should see a button near the bottom of this page to do that (in case you get this notification by email, I turn off emails and focus on the website for notifications FYI): #296 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.