-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next steps on network simplification #291
Comments
Good conversation with Zhao and I this morning, we talked about testing on a small network first and ways to only do the simplification on a subset of ' |
Looks like there's a new release here: https://github.com/nptscot/npt/releases/tag/simplified_network_merge Can you point us to the code that generated this dataset @wangzhao0217 ? We should get #292 merged. @mem48 can you take a look at get get this onto our test website if good? |
Hi @Robinlovelace @mem48 , |
Good stuff Zhao. It's moving in the right direction and better than the tiles currently hosted on our test website! |
This is looking great to me: Source: https://nptscot.github.io/#12.06/55.95122/-3.17407 Credit: @mem48 here: nptscot/nptscot.github.io@6cfb364 This is good enough for now. @wangzhao0217 can you open a new issue to document any remaining issues? Whether or not we prioritise fixing these additional issues is TBC. |
We now have a prototype simplified network, as described here: nptscot/networkmerge#58
I'm opening this issue here because ultimate the code that builds the simple network will live in this repo, tests in .R, .Rmd, or .qmd files can go in the code/tests folder.
Next steps that come to mind:
stplanr
andrsgeo
crs = "EPSG:27700"
argument ofrnet_merge()
(this may depend on upstream changes instplanr
, see bug in geo_buffer ropensci/stplanr#538 and Bug inline_segment()
when using certain values on projected data withrsgeo
implementation ropensci/stplanr#546 )rnet_merge()
on projected data, withx
andy
in EPSG 27700 CRSrnet_x
' to generate a minimal datasetrnet_y
object (OS Open Roads) to only those within a buffer surround thernet_x
and merge on the attributes. Use the following syntax to get only OS roads that are within the buffer, e.g. with the following syntax:rbind()
the resulting merged network back with the originalrnet_x
(the version that excludes the lines to simplify)One idea on the last point: only do simplification on segments that have high cycling potential (e.g. more than 100) under the Go Dutch scenario or which are contained by a buffer around those high cycling segments.
And points from @mem48 in nptscot/networkmerge#8
In terms of re-building the national network, I'm thinking about how to speed-up the process. As a bonus, you could take a look at and try to fix this: ropensci/stplanr#522
All this will help to fix #64 have a simplified network up soon!
The text was updated successfully, but these errors were encountered: