Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on large network example #8

Closed
Robinlovelace opened this issue Jul 28, 2023 · 8 comments
Closed

Test on large network example #8

Robinlovelace opened this issue Jul 28, 2023 · 8 comments

Comments

@Robinlovelace
Copy link
Contributor

I've uploaded a 300 MB file here: https://github.com/nptscot/networkmerge/releases/download/v0.1/large_route_network_example_edingurgh.geojson

@Robinlovelace Robinlovelace mentioned this issue Aug 1, 2023
@wangzhao0217
Copy link
Collaborator

wangzhao0217 commented Oct 8, 2023

Hi @Robinlovelace @mem48
Please find the simplified network here: https://github.com/nptscot/networkmerge/releases/download/v0.1/simplified_network_npt.geojson
It should simplify the network without losing details. Here is a good example:
was:
image
image
now:
image

@Robinlovelace
Copy link
Contributor Author

Looking good Zhao, great work! The method has been tested on a large network, so closing this issue. @mem48 can you try to get that .geojson file tiled and deployed on our web app, assuming it's good to go. From what I can tell it seems much better than what is there currently, putting it on our website may help further debug it and improve on the simplified network outputs.

@mem48 mem48 reopened this Oct 12, 2023
@mem48
Copy link

mem48 commented Oct 12, 2023

@wangzhao0217 a few fixes needed

  1. Outputs need to be transformed to 4326 current output is in the British National Grid
  2. The simplified network is still based on old data with the wrong columns, please use https://github.com/nptscot/outputdata/releases/download/v2023-09-09/combined_network_tile.zip
  3. Please use appropriate coordinate precision to reduce file sizes

@mem48
Copy link

mem48 commented Oct 12, 2023

I've put the latest version on the dev website.

Still see odd results on some side roads. But this may be because you're using an old version of the data.

E.g.
https://nptscot.github.io/#18.21/55.944712/-3.197395
https://nptscot.github.io/#15.73/55.938757/-3.158171
https://nptscot.github.io/#16.64/55.955197/-3.109993
https://nptscot.github.io/#16.5/56.021685/-3.406723

@Robinlovelace
Copy link
Contributor Author

I've put the latest version on the dev website.

Still see odd results on some side roads. But this may be because you're using an old version of the data.

E.g. https://nptscot.github.io/#18.21/55.944712/-3.197395 https://nptscot.github.io/#15.73/55.938757/-3.158171 https://nptscot.github.io/#16.64/55.955197/-3.109993 https://nptscot.github.io/#16.5/56.021685/-3.406723

Good stuff, yes probably because it's an old version of the data. @wangzhao0217 can you update the network ASAP so we can test on the latest version of the data?

@Robinlovelace
Copy link
Contributor Author

Looking at https://nptscot.github.io/#15.64/55.956999/-3.105648 the simplified network has values that are too high on the parallel road. I suggest reducing the size of the buffer, e.g. to 20 or even 15 or 10 m.

image

@Robinlovelace
Copy link
Contributor Author

Closing in favour of nptscot/npt#291

We should focus on applying the method in the npt codebase and eventually integrate into the build.

@wangzhao0217
Copy link
Collaborator

wangzhao0217 commented Oct 15, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants