-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on large network example #8
Comments
Hi @Robinlovelace @mem48 |
Looking good Zhao, great work! The method has been tested on a large network, so closing this issue. @mem48 can you try to get that .geojson file tiled and deployed on our web app, assuming it's good to go. From what I can tell it seems much better than what is there currently, putting it on our website may help further debug it and improve on the simplified network outputs. |
@wangzhao0217 a few fixes needed
|
I've put the latest version on the dev website. Still see odd results on some side roads. But this may be because you're using an old version of the data. E.g. |
Good stuff, yes probably because it's an old version of the data. @wangzhao0217 can you update the network ASAP so we can test on the latest version of the data? |
Looking at https://nptscot.github.io/#15.64/55.956999/-3.105648 the simplified network has values that are too high on the parallel road. I suggest reducing the size of the buffer, e.g. to 20 or even 15 or 10 m. |
Closing in favour of nptscot/npt#291 We should focus on applying the method in the npt codebase and eventually integrate into the build. |
https://nptscot.github.io/#18.21/55.944712/-3.197395
was:
[image: 9b624000-35ba-42bf-a83d-83873eb15625.png][image: image.png]
now:
[image: image.png]
- sidewalk is ignored, but the values are correct within the same band.
…------------------------------------------------------------------------------------------------------------------------------------------------
https://nptscot.github.io/#15.73/55.938757/-3.158171
was:
[image: image.png]
now:
[image: image.png]
- this part is hard to solve. This road's winding caused low value. I
tried to segment it into small lengths. This improved results for the road
only, but affected others.
------------------------------------------------------------------------------------------------------------------------------------------------
https://nptscot.github.io/#16.64/55.955197/-3.109993
[image: image.png][image: 0dd7f8ea-e74f-4b83-a1c0-cced57b27ee8.png]
- The rnet_merge works okay, the difference is caused by the original
data, there are small pieces of the road hidden beneath the grey line.
------------------------------------------------------------------------------------------------------------------------------------------------
https://nptscot.github.io/#16.5/56.021685/-3.406723
was:
[image: image.png][image: image.png]
now:
[image: image.png]
- values are in the correct band.
On Thu, 12 Oct 2023 at 11:12, Robin Lovelace ***@***.***> wrote:
Closing in favour of nptscot/npt#291
<nptscot/npt#291>
We should focus on applying the method in the npt codebase and eventually
integrate into the build.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARZESTTGNWFXAGOEKCBQKGLX667ALANCNFSM6AAAAAA23FN74U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I've uploaded a 300 MB file here: https://github.com/nptscot/networkmerge/releases/download/v0.1/large_route_network_example_edingurgh.geojson
The text was updated successfully, but these errors were encountered: