Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: add simple parse and test benchmarks for URLPattern #56882

Merged
merged 1 commit into from
Feb 4, 2025
Merged

benchmarks: add simple parse and test benchmarks for URLPattern #56882

merged 1 commit into from
Feb 4, 2025

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 2, 2025

Add a couple of simple benchmarks for URLPattern that we can use to help judge performance improvements.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 2, 2025
@jasnell jasnell added whatwg-urlpattern and removed url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 2, 2025
@jasnell jasnell requested review from anonrig and legendecas February 2, 2025 17:55
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/urlpattern-benchmarks branch from abd9d6b to ce74a22 Compare February 2, 2025 17:58
@anonrig
Copy link
Member

anonrig commented Feb 2, 2025

I think you also need to create a file in tests folder for validating the benchmark.

@jasnell
Copy link
Member Author

jasnell commented Feb 2, 2025

I think you also need to create a file in tests folder for validating the benchmark.

Because the new benchmarks are in the url group it's already covered by the existing test-benchmark-url

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2025
mcollina
mcollina approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell force-pushed the jasnell/urlpattern-benchmarks branch from 4c0d9b7 to 2919b1e Compare February 3, 2025 15:26
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/urlpattern-benchmarks branch from 2919b1e to 3273aed Compare February 3, 2025 17:05
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/urlpattern-benchmarks branch from 3273aed to 6c82d76 Compare February 3, 2025 22:24
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/urlpattern-benchmarks branch from 6c82d76 to 5590a15 Compare February 3, 2025 23:48
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64986/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3207fda into nodejs:main Feb 4, 2025
46 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3207fda

targos pushed a commit that referenced this pull request Feb 5, 2025
@jasnell @targos
benchmark: add simple parse and test benchmarks for URLPattern
0ee9c34 
PR-URL: #56882
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@anonrig anonrig anonrig approved these changes

@legendecas legendecas legendecas approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. whatwg-urlpattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @anonrig @mcollina @legendecas @H4ad