Apply suggestions from code review

nodejs · Feb 3, 2025 · 4c0d9b7 · 4c0d9b7
1 parent ce74a22
commit 4c0d9b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/benchmark/url/urlpattern-parse.js b/benchmark/url/urlpattern-parse.js
@@ -1,6 +1,7 @@
 'use strict';
 const common = require('../common.js');
 const { URLPattern } = require('url');
+const { ok } = require('assert');
 
 const tests = [
   'https://(sub.)?example(.com/)foo',
@@ -19,7 +20,8 @@ function main({ pattern, n }) {
   const inputPattern = JSON.parse(pattern);
   bench.start();
   for (let i = 0; i < n; i += 1) {
-    new URLPattern(inputPattern);
+    const p = new URLPattern(inputPattern);
+    ok(p);
   }
   bench.end(n);
 }
diff --git a/benchmark/url/urlpattern-test.js b/benchmark/url/urlpattern-test.js
@@ -1,6 +1,7 @@
 'use strict';
 const common = require('../common.js');
 const { URLPattern } = require('url');
+const { notStrictEqual } = require('assert');
 
 const tests = [
   'https://(sub.)?example(.com/)foo',
@@ -21,7 +22,8 @@ function main({ pattern, n }) {
 
   bench.start();
   for (let i = 0; i < n; i += 1) {
-    urlpattern.test('https://sub.example.com/foo');
+    const p = urlpattern.test('https://sub.example.com/foo');
+    notStrictEqual(p, undefined);  // we don't care if it is true or false.
   }
   bench.end(n);
 }