sqlite: return results with null prototype #54350

targos · 2024-08-13T07:01:07Z

These objects are dictionaries, and a query can return columns with
special names like __proto__ (which would be ignored without this
change).

Also construct the object by passing vectors of properties for better
performance and improve error handling by using MaybeLocal.

These objects are dictionaries, and a query can return columns with special names like `__proto__` (which would be ignored without this change). Also construct the object by passing vectors of properties for better performance and improve error handling by using `MaybeLocal`.

targos · 2024-08-13T08:22:31Z

TIL: tools/test.py sqlite does not run test-sqlite.js

codecov · 2024-08-13T09:40:05Z

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.08%. Comparing base (5f230d2) to head (f4c17c0).
Report is 413 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	81.57%	2 Missing and 5 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #54350   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         647      647           
  Lines      181974   181979    +5     
  Branches    34915    34911    -4     
=======================================
+ Hits       158473   158482    +9     
+ Misses      16787    16783    -4     
  Partials     6714     6714

Files with missing lines	Coverage Δ
src/node_sqlite.h	`0.00% <ø> (ø)`
src/node_sqlite.cc	`84.00% <81.57%> (+1.65%)`	⬆️

... and 20 files with indirect coverage changes

fhinkel

Good catch!

nodejs-github-bot · 2024-08-17T07:28:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/54350
✔  Done loading data for nodejs/node/pull/54350
----------------------------------- PR info ------------------------------------
Title      sqlite: return results with null prototype (#54350)
Author     Michaël Zasso <[email protected]> (@targos)
Branch     targos:sqlite-proto -> nodejs:main
Labels     c++, needs-ci, sqlite
Commits    2
 - sqlite: return results with null prototype
 - fixup
Committers 1
 - Michaël Zasso <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54350
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54350
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 13 Aug 2024 07:01:07 GMT
   ✔  Approvals: 3
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54350#pullrequestreview-2234909899
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54350#pullrequestreview-2235250733
   ✔  - Franziska Hinkelmann (@fhinkel): https://github.com/nodejs/node/pull/54350#pullrequestreview-2241094745
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10430551941

nodejs-github-bot · 2024-08-17T07:33:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61179/

nodejs-github-bot · 2024-08-17T09:48:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61180/

nodejs-github-bot · 2024-08-24T07:21:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61401/

nodejs-github-bot · 2024-08-24T11:43:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61407/

nodejs-github-bot · 2024-08-24T17:06:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61421/

nodejs-github-bot · 2024-08-24T21:02:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61424/

nodejs-github-bot · 2024-08-24T22:41:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61430/

nodejs-github-bot · 2024-08-25T06:11:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61436/

nodejs-github-bot · 2024-08-25T07:20:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61439/

nodejs-github-bot · 2024-08-25T10:11:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61443/

nodejs-github-bot · 2024-08-25T10:43:18Z

Landed in 7fea010

These objects are dictionaries, and a query can return columns with special names like `__proto__` (which would be ignored without this change). Also construct the object by passing vectors of properties for better performance and improve error handling by using `MaybeLocal`. PR-URL: nodejs#54350 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>

These objects are dictionaries, and a query can return columns with special names like `__proto__` (which would be ignored without this change). Also construct the object by passing vectors of properties for better performance and improve error handling by using `MaybeLocal`. PR-URL: #54350 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>

These objects are dictionaries, and a query can return columns with special names like `__proto__` (which would be ignored without this change). Also construct the object by passing vectors of properties for better performance and improve error handling by using `MaybeLocal`. PR-URL: nodejs#54350 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>

louwers · 2024-11-02T21:21:17Z

Ah I was wondering why my tests where failing.

Seems worth it to add a simple helper for deepStrictEqual?

TIL: tools/test.py sqlite does not run test-sqlite.js

Oof...

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Aug 13, 2024

fixup

f4c17c0

benjamingr approved these changes Aug 13, 2024

View reviewed changes

anonrig approved these changes Aug 13, 2024

View reviewed changes

fhinkel approved these changes Aug 15, 2024

View reviewed changes

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 17, 2024

targos added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2024

cjihrig mentioned this pull request Aug 23, 2024

feat(sqlite): add StatementSync.prototype.iterate method #54213

Open

4 tasks

targos added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 24, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2024

jasnell approved these changes Aug 24, 2024

View reviewed changes

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2024

nodejs-github-bot merged commit 7fea010 into nodejs:main Aug 25, 2024
67 checks passed

targos deleted the sqlite-proto branch August 25, 2024 10:49

RafaelGSS mentioned this pull request Aug 30, 2024

v22.8.0 proposal #54560

Merged

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sqlite: return results with null prototype #54350

sqlite: return results with null prototype #54350

targos commented Aug 13, 2024

targos commented Aug 13, 2024

codecov bot commented Aug 13, 2024 •

edited

Loading

fhinkel left a comment

nodejs-github-bot commented Aug 17, 2024

nodejs-github-bot commented Aug 17, 2024

nodejs-github-bot commented Aug 17, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

louwers commented Nov 2, 2024

sqlite: return results with null prototype #54350

sqlite: return results with null prototype #54350

Conversation

targos commented Aug 13, 2024

targos commented Aug 13, 2024

codecov bot commented Aug 13, 2024 • edited Loading

Codecov Report

fhinkel left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 17, 2024

nodejs-github-bot commented Aug 17, 2024

nodejs-github-bot commented Aug 17, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 24, 2024

nodejs-github-bot commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

nodejs-github-bot commented Aug 25, 2024

louwers commented Nov 2, 2024

codecov bot commented Aug 13, 2024 •

edited

Loading