Skip to content

Commit

Permalink
sqlite: return results with null prototype
Browse files Browse the repository at this point in the history
These objects are dictionaries, and a query can return columns with
special names like `__proto__` (which would be ignored without this
change).

Also construct the object by passing vectors of properties for better
performance and improve error handling by using `MaybeLocal`.

PR-URL: nodejs#54350
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
targos authored and louwers committed Aug 25, 2024
1 parent d0e558b commit c384e40
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/node_sqlite.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ using v8::FunctionTemplate;
using v8::Integer;
using v8::Isolate;
using v8::Local;
using v8::NewStringType;
using v8::LocalVector;
using v8::MaybeLocal;
using v8::Name;
Expand Down

0 comments on commit c384e40

Please sign in to comment.