Merge fixtures: available_port into llm_server #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
changed the title
renxida
force-pushed
the
temporarily-disable-concurrent
branch
from
a748bbb to
164dddb
Compare
renxida
changed the title
renxida
changed the title
stbaione
approved these changes
Jan 6, 2025
monorimet
pushed a commit
that referenced
this pull request
Jan 8, 2025
The available_ports fixture seems to rely on the servers booting very quickly to work. Merging it into the llm_server & increasing the server startup timeout fixes the remaining CI failures caused by updating IREE to 1220.
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available_ports fixture seems to rely on the servers booting very quickly to work. Merging it into the llm_server & increasing the server startup timeout fixes the remaining CI failures caused by updating IREE to 1220.