Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase app_tests/integration_tests/llm/utils.py server start timeout #743

Closed
wants to merge 1 commit into from
Closed

increase app_tests/integration_tests/llm/utils.py server start timeout #743

wants to merge 1 commit into from

Conversation

renxida
Copy link
Contributor

@renxida renxida commented Jan 3, 2025

No description provided.

ScottTodd
ScottTodd reviewed Jan 3, 2025
View reviewed changes
app_tests/integration_tests/llm/utils.py
def wait_for_server(url, timeout=10):
def wait_for_server(url, timeout=60):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, unit tests also failed to start the server after some IREE changes, noted on #722 (comment).

@renxida
Copy link
Contributor Author

renxida commented Jan 14, 2025 •
edited
Loading

#758 ends up being the real fix - - these were failing due to iree init time being different causing a race condition over server listen ports across different test cases. #758 ends up adjusting both the ports and the timeout.

@renxida renxida closed this Jan 14, 2025
@renxida renxida deleted the increase-cpu_llm_test-server-start-timeout branch January 14, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renxida @ScottTodd