-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PC-11745 Add primary objective terraform support #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgtm 👌🏻 |
natalialanga
added a commit
to nobl9/sloctl
that referenced
this pull request
Mar 29, 2024
## Summary Add primary objective sloctl support ## Related changes nobl9/nobl9-go#330 nobl9/terraform-provider-nobl9#202
lukasz-dobek
previously approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the assumption that we will release 0.25 😄
nieomylnieja
requested changes
Apr 8, 2024
nieomylnieja
approved these changes
Apr 8, 2024
BSski
pushed a commit
to nobl9/sloctl
that referenced
this pull request
May 7, 2024
## Summary Add primary objective sloctl support ## Related changes nobl9/nobl9-go#330 nobl9/terraform-provider-nobl9#202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
go
Pull requests that update Go code
minor
New functionality with at most minor breaking changes
passed-testing
Added by QA when tests have passed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Expose new field 'primary' to highlight a specific objective in an SLO.
Summary
Add primary objective terraform support
Related changes
nobl9/nobl9-go#330
nobl9/sloctl#83
Testing
Build a local provider with make install and use the sample .tf file for testing.
Sample .tf file: