feat: PC-11745 Add primary objective sloctl support #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalialanga
changed the title
lukasz-dobek
approved these changes
Mar 21, 2024
|
lgtm |
natalialanga
added a commit
to nobl9/terraform-provider-nobl9
that referenced
this pull request
Apr 8, 2024
## Release Notes Expose new field 'primary' to highlight a specific objective in an SLO. ## Summary Add primary objective terraform support ## Related changes nobl9/nobl9-go#330 nobl9/sloctl#83 ## Testing Build a local provider with make install and use the sample .tf file for testing. Sample .tf file: ``` terraform { required_providers { nobl9 = { source = "nobl9.com/nobl9/nobl9" version = "0.25.0" } } } // Fill using nobl9 auth configuration provider "nobl9" { ingest_url = "" okta_org_url = "" okta_auth_server = "" client_id = "" client_secret = "" } resource "nobl9_slo" "this" { name = "slo" service = "service" budgeting_method = "Occurrences" project = "project" time_window { unit = "Day" count = 30 is_rolling = true } objective { name = "obj-1" target = 0.99 value = 2000 op = "gte" primary = true raw_metric { query { prometheus { promql = "query" } } } } indicator { name = "test-prom-agent" } } ```
BSski
pushed a commit
that referenced
this pull request
May 7, 2024
## Summary Add primary objective sloctl support ## Related changes nobl9/nobl9-go#330 nobl9/terraform-provider-nobl9#202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add primary objective sloctl support
Related changes
nobl9/nobl9-go#330
nobl9/terraform-provider-nobl9#202