.gitignore entry for macOs; removed unsupported honeycomb metric type…

…s; added validation for raw metrics - forbidden

.gitignore

@@ -5,6 +5,9 @@
 *.so
 *.dylib
 
+# macOs specific files
+.DS_Store
+
 # Test binary, built with `go test -c`
 *.test
 

internal/manifest/v1alpha/examples/slo.go

@@ -120,9 +120,6 @@ var customMetricExamples = map[v1alpha.DataSourceType]map[metricVariant][]metric
 	},
 	v1alpha.Honeycomb: {
 		metricVariantSingleQueryGoodRatio: []metricSubVariant{},
-		metricVariantGoodRatio:            []metricSubVariant{},
-		metricVariantBadRatio:             []metricSubVariant{},
-		metricVariantThreshold:            []metricSubVariant{},
 	},
 	v1alpha.Splunk: {
 		metricVariantSingleQueryGoodRatio: []metricSubVariant{},

internal/manifest/v1alpha/examples/slo_variants.go

@@ -987,27 +987,6 @@ func (s sloExample) generateMetricVariant(slo v1alphaSLO.SLO) v1alphaSLO.SLO {
 		}
 	case v1alpha.Honeycomb:
 		switch s.MetricVariant {
-		case metricVariantThreshold:
-			return setThresholdMetric(slo, newMetricSpec(v1alphaSLO.HoneycombMetric{
-				Calculation: "AVG",
-				Attribute:   "requestsLatency",
-			}))
-		case metricVariantGoodRatio:
-			return setGoodOverTotalMetric(slo, newMetricSpec(v1alphaSLO.HoneycombMetric{
-				Calculation: "SUM",
-				Attribute:   "counterGood",
-			}), newMetricSpec(v1alphaSLO.HoneycombMetric{
-				Calculation: "SUM",
-				Attribute:   "counterTotal",
-			}))
-		case metricVariantBadRatio:
-			return setBadOverTotalMetric(slo, newMetricSpec(v1alphaSLO.HoneycombMetric{
-				Calculation: "SUM",
-				Attribute:   "counterBad",
-			}), newMetricSpec(v1alphaSLO.HoneycombMetric{
-				Calculation: "SUM",
-				Attribute:   "counterTotal",
-			}))
 		case metricVariantSingleQueryGoodRatio:
 			return setSingleQueryGoodOverTotalMetric(slo, newMetricSpec(v1alphaSLO.HoneycombMetric{
 				Attribute: "dc.sli.some-service-availability",