forbid fawmetric for honeycomb

nobl9 · Jan 23, 2025 · 6fc6aed · 6fc6aed
1 parent 9971a68
commit 6fc6aed
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/manifest/v1alpha/slo/metrics_honeycomb.go b/manifest/v1alpha/slo/metrics_honeycomb.go
@@ -18,3 +18,9 @@ var honeycombSingleQueryValidation = govy.New[HoneycombMetric](
 			rules.StringMaxLength(255),
 			rules.StringNotEmpty()),
 )
+
+var honeycombRawMetricValidation = govy.New[MetricSpec](
+	govy.For(func(m MetricSpec) *HoneycombMetric { return m.Honeycomb }).
+		WithName("honeycomb").
+		Rules(rules.Forbidden[*HoneycombMetric]()),
+)
diff --git a/manifest/v1alpha/slo/metrics_honeycomb_test.go b/manifest/v1alpha/slo/metrics_honeycomb_test.go
@@ -55,11 +55,11 @@ func TestHoneycomb_singleQuery(t *testing.T) {
 	})
 }
 
-func TestHoneycomb_rawMetrics(t *testing.T) {
+func TestHoneycomb_rawMetrics_forbidded(t *testing.T) {
 	slo := validRawMetricSLO(v1alpha.Honeycomb)
 	err := validate(slo)
 	testutils.AssertContainsErrors(t, slo, err, 1, testutils.ExpectedError{
-		Prop: "spec.objectives[0].rawMetric",
+		Prop: "spec.objectives[0].rawMetric.query.honeycomb",
 		Code: rules.ErrorCodeForbidden,
 	})
 }

diff --git a/manifest/v1alpha/slo/metrics_validation.go b/manifest/v1alpha/slo/metrics_validation.go
@@ -129,7 +129,9 @@ var RawMetricsValidation = govy.New[RawMetricSpec](
 			lightstepRawMetricValidation,
 			pingdomRawMetricValidation,
 			thousandEyesRawMetricValidation,
-			instanaRawMetricValidation),
+			instanaRawMetricValidation,
+			honeycombRawMetricValidation,
+		),
 )
 
 var countMetricsValidation = govy.New[MetricSpec](