-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add D-M, random seed argument, and code improvements #6
base: main
Are you sure you want to change the base?
Conversation
…objection by default
@Cole-Monnahan-NOAA do you have a D-M example we could add? maybe to the existing GOA pk script? |
Hi Jane, I didn't make one. Perhaps we should consider moving away from the packaged examples and just use simulated data for both the MN and DM. That'd be easier on the user side. We could keep the existing scripts and perhaps they'd be better used as tests for when we make changes. If you approve this idea I'll update the PR. |
i agree we need some tests. i can see the benefit of using simulated data sets. i had used real life examples so that new users could follow a workflow that most closely resembled their own model (SS3, AMAK, or some other bespoke ADMB model). but, your point is valid i think. |
@JaneSullivan-NOAA I signed myself up for that idea in this issue but suggest we have that as a separate PR to keep things a little more organized. So I'll do another PR once this one is done and merged in. Any objections? |
Done with this commit: Also moved the position and allow the user to adjust that via arguments |
Edited to add point 5.
This PR does five things:
theta
.plot_osa
so that the user has more control with theplot
argument.addCI
argument) and more flexible placement of the label on QQ plots (viahjust
andvjust
)