Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure examples and create formal tests #8

Open
Cole-Monnahan-NOAA opened this issue Nov 21, 2024 · 3 comments
Open

Restructure examples and create formal tests #8

Cole-Monnahan-NOAA opened this issue Nov 21, 2024 · 3 comments
Assignees
@Cole-Monnahan-NOAA

Comments

@Cole-Monnahan-NOAA
Copy link
Collaborator

The package would benefit from some simpler examples that users could run more easily, and I think using simulated data would be a more straightforward approach.

Some formal tests would also be welcome since the package is still in early development and we expect changes in the coming year.
@Cole-Monnahan-NOAA Cole-Monnahan-NOAA self-assigned this Nov 21, 2024
@Cole-Monnahan-NOAA Cole-Monnahan-NOAA mentioned this issue Nov 21, 2024
Open
@JaneSullivan-NOAA
Copy link
Collaborator

Love it. Could we add confidence intervals to the SDNRs as part of this PR?

@Cole-Monnahan-NOAA
Copy link
Collaborator Author

Yeah that's doable. I'll add a flag to turn them on/off too. Francis suggests only doing upper limit but I think for compositions we want a two-sided CI.

@Cole-Monnahan-NOAA
Copy link
Collaborator Author

Added to this PR #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cole-Monnahan-NOAA Cole-Monnahan-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cole-Monnahan-NOAA @JaneSullivan-NOAA