Add an editor config, a mvn goal and a ci action to check code conventions #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just FYI to see what the kind of code convention problems are check the output of the github action. |
josteinaj
reviewed
Nov 1, 2021
|
Looks great, thanks @egli! |
josteinaj
approved these changes
Nov 1, 2021
|
I'm not sure how to change the base branch of a PR, but I merged it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cross editor config file, a Maven goal that uses the config to check the source code and finally a github action to check every commit for these conventions via maven.
Should fix at least in part #476.
When running the mvn goal quite a few files have problems. These can easily be fixed with
mvn editorconfig:format. But I think such a global change should go in a separate PR.