Formatted code using EditorConfig #508
Conversation
| </xsl:text> | ||
| </xsl:text> |
There was a problem hiding this comment.
Presumably this is not the same as before. The old code inserts a newline and no spaces. The new code inserts a newline and some spaces.
I tried the test suite and it passes. Are these additional spaces harmless?
There was a problem hiding this comment.
Good point. It seems harmless, but the intention is to only insert a newline, so we should fix this. Maybe we could add a xml:space="preserve" on the xsl:text if EditorConfig respects that. Alternatively we could say <xsl:text>
</xsl:text> or <xsl:value-of select="'\n'"/>or similar.
There was a problem hiding this comment.
add a
xml:space="preserve"on thexsl:textif EditorConfig respects that
I doubt EditorConfig is that smart :-)
Alternatively we could say
<xsl:text>
</xsl:text>
That seems like the most straight forward solution
| @@ -44,7 +44,7 @@ | |||
| public static void main(String[] args) { | |||
| ... | |||
| } | |||
| </code></p> | |||
| </code></p> | |||
There was a problem hiding this comment.
same newline issue here, we could maybe try either xml:space="preserve" on the <code> or }
</code>
| @@ -510,7 +510,7 @@ | |||
| public static void main(String[] args) { | |||
| ... | |||
| } | |||
| </code></p> | |||
| </code></p> | |||
| </xsl:text> | ||
| </xsl:text> |
| @@ -54,23 +54,23 @@ | |||
| </xsl:if> | |||
| </head> | |||
| <xsl:text> | |||
| </xsl:text> | |||
| </xsl:text> | |||
| </html> | ||
| <xsl:text> | ||
| </xsl:text> | ||
| </xsl:text> |
| </body> | ||
| <xsl:text> | ||
| </xsl:text> | ||
| </xsl:text> |
| <xsl:apply-templates select="$body/*"/> | ||
| <xsl:text> | ||
| </xsl:text> | ||
| </xsl:text> |
| <body> | ||
| <xsl:apply-templates select="$body/(@* except @xml:base)"/> | ||
| <xsl:if test="$body[self::header]"> | ||
| <xsl:attribute name="epub:type" select="string-join(('frontmatter','titlepage',tokenize($body/@epub:type,'\s+')),' ')"/> | ||
| </xsl:if> | ||
| <xsl:text> | ||
| </xsl:text> | ||
| </xsl:text> |
| @@ -44,7 +44,7 @@ | |||
| public static void main(String[] args) { | |||
| ... | |||
| } | |||
| </code></p> | |||
| </code></p> | |||
| @@ -563,7 +563,7 @@ | |||
| public static void main(String[] args) { | |||
| ... | |||
| } | |||
| </code></p> | |||
| </code></p> | |||
|
merged into |
Follow-up from #507.