REL: 1.5.0 #3174
Merged
REL: 1.5.0 #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3174 +/- ##
==========================================
- Coverage 65.07% 65.06% -0.02%
==========================================
Files 301 301
Lines 39624 39624
Branches 5247 5247
==========================================
- Hits 25786 25781 -5
- Misses 12771 12776 +5
Partials 1067 1067
Continue to review full report at Codecov.
|
|
Hey, Sorry for the delay in submitting this. { |
effigies
force-pushed
the
rel/1.5.0
branch
2 times, most recently
from
be4e46d to
84d48f4
Compare
|
@miykael @djarecka Any chance one of you could have a look at https://circleci.com/workflow-run/6eba71d4-5cb8-4711-b95a-83d7393dd71c? For reference, here's the diff between that branch and |
|
Sure. I don't see much prospect of fixing the tutorials soon, so the release is held up for now. Squeeze in as you like. |
|
Mark,
Could you blacklist me? My contribution was insignificant and I give up any
rights to my contribution(s) (you can license or re-license however you
want).
Thanks!
Jonathan
…On Sat, Feb 22, 2020 at 7:54 PM Chris Markiewicz ***@***.***> wrote:
Summary
Prep for new feature release 1.5.0, targeting release on Monday, February
24.
Given that we just released 1.4.2 about a week ago, I'm inclined to hold
this one off for any feature PRs that would like to shoot for inclusion.
Require merge or postponement decision on all issues/PRs in
https://github.com/nipy/nipype/milestone/38:
- ENH: Add a Bandpass filter interface under algorithms.filters #2915
<#2915> ***@***.***
<https://github.com/oesteban>)
- [WIP/ENH] Adds a new interface for AFNI's 3dMEMA command #2953
<#2953> ***@***.***
<https://github.com/JesseyWright> / @oesteban
<https://github.com/oesteban>)
- ENH: Add interface for fslorient #2955
<#2955> ***@***.***
<https://github.com/felixsc1>)
- [FIX] Mrtrix3 usedefault issue (#3004
<#3004>) ***@***.***
<https://github.com/matteomancini>)
- [DOC] SelectFiles docstring corrected #3041
<#3041> ***@***.***
<https://github.com/AKSoo>)
- FIX Ants N4BiasFieldCorrection rescale_intensities bug #3139
<#3139> ***@***.***
<https://github.com/salma1601>)
- CI: Test Python 3.8 #3154 <#3154>
***@***.*** <https://github.com/effigies>)
- ENH: Detect values for EulerNumber interface #3173
<#3173> ***@***.***
<https://github.com/mgxd>)
Will try review the open PRs and see if anything is close enough to push
on, tomorrow.
Release checklist
- Merge pending PRs
- Update changelog
- Update .mailmap
- Update .zenodo.json
- Set release number in nipype/info.py
- Update doc/interfaces.rst with previous releases
- Check conda-forge feedstock build (conda-forge/nipype-feedstock#65
<conda-forge/nipype-feedstock#65>)
- Tutorial tests (
https://circleci.com/workflow-run/aa70a094-fd7f-4b80-b6a3-e573b1f5400d)
Uncredited authors
The following authors have contributed, but not added themselves to the
.zenodo.json <https://github.com/nipy/nipype/blob/master/.zenodo.json>
file. If you would like to be an author on Zenodo releases, please add
yourself or comment with your preferred publication name, affiliation and
ORCID <https://orcid.org/>. If you would like to stop being spammed
whenever I'm the one doing releases, let me know, and I'll add you to a
blacklist.
No entry to sort: cdla ***@***.*** <https://github.com/cdla>)
No entry to sort: Gio Piantoni ***@***.*** <https://github.com/gpiantoni>)
No entry to sort: Victor Férat ***@***.*** <https://github.com/vferat>)
No entry to sort: Niklas Förster ***@***.***
<https://github.com/niklasfoe>)
No entry to sort: Adam Kimbler ***@***.***
<https://github.com/adamkimbler>)
No entry to sort: Kirstie Whitaker ***@***.***
<https://github.com/KirstieJane>)
No entry to sort: Pablo Polosecki ***@***.***
<https://github.com/polosecki>)
No entry to sort: Ami Tsuchida
No entry to sort: Daniel Brenner ***@***.***
<https://github.com/brennerd11>)
No entry to sort: Isaiah Norton ***@***.*** <https://github.com/ihnorton>)
No entry to sort: Kevin Sitek ***@***.*** <https://github.com/sitek>)
No entry to sort: Luke Bloy ***@***.*** <https://github.com/bloyl>)
No entry to sort: Martin Luessi ***@***.*** <https://github.com/mluessi>)
No entry to sort: steve ***@***.*** <https://github.com/steve19922>)
No entry to sort: Charl Linssen ***@***.***
<https://github.com/turingbirds>)
No entry to sort: Félix C. Morency ***@***.***
<https://github.com/fmorency>)
No entry to sort: Jonathan R. Williford ***@***.***
<https://github.com/williford>)
No entry to sort: Michiel Cottaar ***@***.***
<https://github.com/MichielCottaar>)
No entry to sort: Regina Kim ***@***.*** <https://github.com/reginakim>)
No entry to sort: Valentin Haenel ***@***.*** <https://github.com/esc>)
No entry to sort: Xu Wang
No entry to sort: maedoc ***@***.*** <https://github.com/maedoc>)
I am unable to find GitHub handles for Ami Tsuchida or Xu Wang.
Apologies also to anybody who may have
Acknowledgment
- (Mandatory) I acknowledge that this contribution will be available
under the Apache 2 license.
------------------------------
You can view, comment on, or merge this pull request online at:
#3174
Commit Summary
- NEP29+1y: Set minimum numpy to 1.13
- DOC: Update changelog
- MNT: Update Zenodo ordering
- MNT: 1.5.0
File Changes
- *M* .zenodo.json
<https://github.com/nipy/nipype/pull/3174/files#diff-0> (30)
- *M* doc/changelog/1.X.X-changelog.rst
<https://github.com/nipy/nipype/pull/3174/files#diff-1> (17)
- *M* nipype/info.py
<https://github.com/nipy/nipype/pull/3174/files#diff-2> (4)
Patch Links:
- https://github.com/nipy/nipype/pull/3174.patch
- https://github.com/nipy/nipype/pull/3174.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3174?email_source=notifications&email_token=AAHV53EVFGL6E4F4KJDKHM3REHCL5A5CNFSM4KZWEA2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPQTL2Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHV53CD2B5AF6SMV7OC3XDREHCL5ANCNFSM4KZWEA2A>
.
|
|
While we figure out the notebooks problem, could we maybe push an RC? |
|
Sure. |
|
I'm fine either way. I don't think we really need this RC other than in Pypi |
|
Sorry, should have updated. Rerendering the feedstock worked. 1.5.0rc1 is on PyPI and conda-forge. |
… ANTS Registration outputs.
FIX: Use PackageInfo to get NiftyReg version
TEST: Mock terminal output before testing changing default value
ENH: Add reverse-ordered transform lists to ants.Registration outputs
TEST: Clean up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prep for new feature release 1.5.0, targeting release on Monday, February 24.
Given that we just released 1.4.2 about a week ago, I'm inclined to hold this one off for any feature PRs that would like to shoot for inclusion.
Require merge or postponement decision on all issues/PRs in https://github.com/nipy/nipype/milestone/38:
Bandpassfilter interface underalgorithms.filtersENH: Add aBandpassfilter interface underalgorithms.filters#2915 (@oesteban)3dMEMAcommand [WIP/ENH] Adds a new interface for AFNI's3dMEMAcommand #2953 (@JesseyWright / @oesteban)Will try review the open PRs and see if anything is close enough to push on, tomorrow.
Release checklist
nipype/info.pydoc/interfaces.rstwith previous releasesUncredited authors
The following authors have contributed, but not added themselves to the
.zenodo.jsonfile. If you would like to be an author on Zenodo releases, please add yourself or comment with your preferred publication name, affiliation and ORCID. If you would like to stop being spammed whenever I'm the one doing releases, let me know, and I'll add you to a blacklist.No entry to sort: cdla (@cdla)
No entry to sort: Gio Piantoni (@gpiantoni)
No entry to sort: Victor Férat (@vferat)
No entry to sort: Niklas Förster (@niklasfoe)
No entry to sort: Adam Kimbler (@adamkimbler)No entry to sort: Kirstie Whitaker (@KirstieJane)
No entry to sort: Pablo Polosecki (@polosecki)
No entry to sort: Ami Tsuchida
No entry to sort: Daniel Brenner (@brennerd11)
No entry to sort: Isaiah Norton (@ihnorton)
No entry to sort: Kevin Sitek (@sitek)
No entry to sort: Luke Bloy (@bloyl)
No entry to sort: Martin Luessi (@mluessi)
No entry to sort: steve (@steve19922)
No entry to sort: Charl Linssen (@turingbirds)
No entry to sort: Félix C. Morency (@fmorency)
No entry to sort: Jonathan R. Williford (@williford)No entry to sort: Michiel Cottaar (@MichielCottaar)
No entry to sort: Regina Kim (@reginakim)
No entry to sort: Valentin Haenel (@esc)
No entry to sort: Xu Wang
No entry to sort: maedoc (@maedoc)
I am unable to find GitHub handles for Ami Tsuchida or Xu Wang.
Apologies also to anybody who may have
Acknowledgment