Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 1.5.0 #3199

Merged
merged 4 commits into from
Jun 3, 2020
Merged

REL: 1.5.0 #3199

merged 4 commits into from
Jun 3, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Mar 31, 2020

Summary

Accidentally closed #3174 by trying to keep master synced with 1.5.0-rc1.post-dev.

Prep for new feature release 1.5.0, targeting release when we can manage it.

Require merge or postponement decision on all issues/PRs in https://github.com/nipy/nipype/milestone/38:

Will try review the open PRs and see if anything is close enough to push on, tomorrow.

Release checklist

Uncredited authors

The following authors have contributed, but not added themselves to the .zenodo.json file. If you would like to be an author on Zenodo releases, please add yourself or comment with your preferred publication name, affiliation and ORCID. If you would like to stop being spammed whenever I'm the one doing releases, let me know, and I'll add you to a blacklist.

No entry to sort: cdla (@cdla)
No entry to sort: Gio Piantoni (@gpiantoni)
No entry to sort: Victor Férat (@vferat)
No entry to sort: Niklas Förster (@niklasfoe)
No entry to sort: Kirstie Whitaker (@KirstieJane)
No entry to sort: Pablo Polosecki (@polosecki)
No entry to sort: Ami Tsuchida
No entry to sort: Daniel Brenner (@brennerd11)
No entry to sort: Isaiah Norton (@ihnorton)
No entry to sort: Kevin Sitek (@sitek)
No entry to sort: Luke Bloy (@bloyl)
No entry to sort: Martin Luessi (@mluessi)
No entry to sort: steve (@steve19922)
No entry to sort: Charl Linssen (@turingbirds)
No entry to sort: Félix C. Morency (@fmorency)
No entry to sort: Michiel Cottaar (@MichielCottaar)
No entry to sort: Regina Kim (@reginakim)
No entry to sort: Valentin Haenel (@esc)
No entry to sort: Xu Wang
No entry to sort: maedoc (@maedoc)

I am unable to find GitHub handles for Ami Tsuchida or Xu Wang.

Apologies also to anybody who may have added themselves previously and been removed by the automated reordering. I think that's fixed these days.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #3199 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
- Coverage   64.99%   64.95%   -0.05%     
==========================================
  Files         302      302              
  Lines       39929    39929              
  Branches     5279     5279              
==========================================
- Hits        25952    25936      -16     
- Misses      12917    12928      +11     
- Partials     1060     1065       +5     
Flag Coverage Δ
#unittests 64.95% <100.00%> (-0.05%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 87.69% <100.00%> (-4.62%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 65.68% <0.00%> (-3.44%) ⬇️
nipype/pipeline/plugins/base.py 58.08% <0.00%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd9b55...94f25c1. Read the comment docs.

@effigies
Copy link
Member Author

@satra Because reverting to older nipype that was known to pass the tutorials still fails the CI tests, I wonder if we shouldn't go ahead and release 1.5.0 (merging in master and updating changelog/contributors, of course).

I know @djarecka is debugging the tutorials again, but I would suggest setting a reasonable time limit to see if she can make it happen and otherwise going on with the release.

@satra
Copy link
Member

satra commented May 20, 2020

@effigies - seems like a reasonable plan.

@effigies
Copy link
Member Author

effigies commented Jun 2, 2020

@sulantha2006, @jhuguetn, @ZviBaratz, @daniel-ge I would like to add you to the authors list on the Zenodo file. Is that okay, and what name, affiliation and ORCID would you like added?

@sulantha2006
Copy link
Contributor

sulantha2006 commented Jun 3, 2020 via email

@ZviBaratz
Copy link
Contributor

Gladly.

Zvi Baratz
Sagol School of Neuroscience, Tel Aviv University

Thank you!

@jhuguetn
Copy link
Contributor

jhuguetn commented Jun 3, 2020

Sure, thanks @effigies

Jordi Huguet
BarcelonaBeta Brain Research Center
orcid.org/0000-0001-8420-4833

@daniel-ge
Copy link
Contributor

Hi Chris, yes, that would be great. Please use the following:

Daniel Geisler

Division of Psychological and Social Medicine and Developmental Neuroscience, Faculty of Medicine, Technische Universität Dresden, Dresden, Germany

https://orcid.org/0000-0003-2076-5329

Thank you,
Daniel

@effigies effigies merged commit 72945ef into master Jun 3, 2020
@effigies effigies deleted the rel/1.5.0 branch June 3, 2020 15:09
@effigies effigies added this to the 1.5.0 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants