Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add active, planned and completed session tabs #1838

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Add active, planned and completed session tabs #1838

merged 3 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Refactor session scopes 

    This refactors the date scopes for sessions to matching the naming
convention we'll be using the UI, and to fix the queries to work with
the new multiple session dates.

Ideally the `today` scope would be named `active`, but this clashes with
the `active` column. Eventually I think we'll be able to rename this
when we create sessions automatically from locations.
    @thomasleese
    thomasleese committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ed325b7 View commit details
    Browse the repository at this point in the history

  2. Use AppSecondaryNavigationComponent text argument 

    This avoids needing to pass a block which looks a little odd when it's
a hard coded string.
    @thomasleese
    thomasleese committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    55b7a51 View commit details
    Browse the repository at this point in the history

  3. Add active, planned and completed session tabs 

    This adds new tabs to the "School sessions" page allowing the user to
see the sessions that are active, planned in the future, and already
completed in the past.
    @thomasleese
    thomasleese committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5461fc6 View commit details
    Browse the repository at this point in the history