Add active, planned and completed session tabs #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the date scopes for sessions to matching the naming convention we'll be using the UI, and to fix the queries to work with the new multiple session dates. Ideally the `today` scope would be named `active`, but this clashes with the `active` column. Eventually I think we'll be able to rename this when we create sessions automatically from locations.
This avoids needing to pass a block which looks a little odd when it's a hard coded string.
This adds new tabs to the "School sessions" page allowing the user to see the sessions that are active, planned in the future, and already completed in the past.
|
Merged
tvararu
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new tabs to the "School sessions" page allowing the user to see the sessions that are active, planned in the future, and already completed in the past.
I've also refactored the date scopes for sessions to matching the naming convention we'll be using the UI, and to fix the queries to work with the new multiple session dates.
Ideally the
todayscope would be namedactive, but this clashes with theactivecolumn. Eventually I think we'll be able to rename this when we create sessions automatically from locations.Screenshots