Schema: rewrite to run local only and handle newer schema versions #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # nf_core/utils.py
mirpedrol
reviewed
Aug 20, 2024
There was a problem hiding this comment.
I'm not sure if it's because I am trying on gitpid, but I get an error when opening the URL
These are the debug logs:
DEBUG Starting new HTTP connection (1): localhost:8000 connectionpool.py:243
DEBUG POST request received server.py:44
DEBUG "POST /process-schema HTTP/1.1" 200 - server.py:102
DEBUG http://localhost:8000 "POST /process-schema HTTP/10" 200 None connectionpool.py:546
DEBUG Got response from nf-core API: received utils.py:479
INFO Opening URL: http://localhost:8000/schema_builder.html?schema_path=nextflow_schema.json schema.py:908
INFO Waiting for form to be completed in the browser. Remember to click Finished when you're done. schema.py:910
⣾ Use ctrl+c to stop waiting and force exit.DEBUG Starting new HTTP connection (1): localhost:8000 connectionpool.py:243
DEBUG "GET /process-schema?schema_path=nextflow_schema.json HTTP/1.1" 200 - server.py:102
DEBUG http://localhost:8000 "GET /process-schema?schema_path=nextflow_schema.json HTTP/10" 200 None connectionpool.py:546
DEBUG Got response from nf-core API: waiting_for_user utils.py:479
| item.a_path for item in repo.index.diff(None) | ||
| ]: | ||
| if not Confirm.ask( | ||
| f""":exclamation_mark: '{str(self.schema_filename)}' has uncommitted changes. These will be overwritten in the following steps. Do you still want to continue""", |
There was a problem hiding this comment.
I think this is always thrown? I just tested with a fresh pipeline and I see this logging:
INFO [✓] Default parameters match schema validation
INFO [✓] Pipeline schema looks valid (found 32 params)
INFO Writing schema with 32 params: 'nextflow_schema.json'
🚀 Launch web builder for customisation and editing? [y/n] (y):
❗ 'nextflow_schema.json' has uncommitted changes. These will be overwritten in the following steps. Do you still want to
continue [y/n] (y):
|
Hmm, I think gitpod is looking at the wrong port. Let me check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.